Merge "Improved Velocity Module" #69 from 4drian3d/velocity

Improved Velocity Module

CommandWhitelistCommon/src/main/java/eu/endermite/commandwhitelist/common/commands/CWCommand.java

@@ -3,6 +3,7 @@ package eu.endermite.commandwhitelist.common.commands;
 import eu.endermite.commandwhitelist.common.CWGroup;
 import eu.endermite.commandwhitelist.common.ConfigCache;
 import net.kyori.adventure.text.Component;
+import net.kyori.adventure.text.TextComponent;
 import net.kyori.adventure.text.format.NamedTextColor;
 import net.kyori.adventure.text.minimessage.MiniMessage;
 import java.util.ArrayList;
@@ -31,20 +32,20 @@ public class CWCommand {
     }
 
     public static Component helpComponent(String baseCommand, boolean showReloadCommand, boolean showAdminCommands) {
-        Component component = miniMessage.deserialize("<rainbow><bold>CommandWhitelist by YouHaveTrouble</bold>")
+        final TextComponent.Builder builder = Component.text();
-                .append(Component.newline());
+        builder.append(miniMessage.deserialize("<rainbow><bold>CommandWhitelist by YouHaveTrouble</bold>"), Component.newline());
-        component = component.append(Component.text(baseCommand + " help").color(NamedTextColor.AQUA).append(Component.text(" - Displays this message").color(NamedTextColor.BLUE)));
+        builder.append(Component.text(baseCommand + " help", NamedTextColor.AQUA), Component.text(" - Displays this message", NamedTextColor.BLUE));
         if (showReloadCommand) {
-            component = component.append(Component.newline());
+            builder.append(Component.newline());
-            component = component.append(Component.text(baseCommand + " reload").color(NamedTextColor.AQUA).append(Component.text(" - Reloads plugin configuration").color(NamedTextColor.BLUE)));
+            builder.append(Component.text(baseCommand + " reload", NamedTextColor.AQUA), Component.text(" - Reloads plugin configuration", NamedTextColor.BLUE));
         }
         if (showAdminCommands) {
-            component = component.append(Component.newline());
+            builder.append(Component.newline());
-            component = component.append(Component.text(baseCommand + " add <group> <command>").color(NamedTextColor.AQUA).append(Component.text(" - Add a command to selected permission group").color(NamedTextColor.BLUE)));
+            builder.append(Component.text(baseCommand + " add <group> <command>", NamedTextColor.AQUA), Component.text(" - Add a command to selected permission group", NamedTextColor.BLUE));
-            component = component.append(Component.newline());
+            builder.append(Component.newline());
-            component = component.append(Component.text(baseCommand + " remove <group> <command>").color(NamedTextColor.AQUA).append(Component.text(" - Removes a command from selected permission group").color(NamedTextColor.BLUE)));
+            builder.append(Component.text(baseCommand + " remove <group> <command>", NamedTextColor.AQUA), Component.text(" - Removes a command from selected permission group", NamedTextColor.BLUE));
         }
-        return component;
+        return builder.build();
     }
 
     public enum CommandType {

CommandWhitelistVelocity/pom.xml

@@ -50,6 +50,16 @@
                                     <shadedPattern>eu.endermite.bstats</shadedPattern>
                                 </relocation>
                             </relocations>
+                            <artifactSet>
+                                <excludes>
+                                    <exclude>net.kyori:adventure-api</exclude>
+                                    <exclude>net.kyori:adventure-key</exclude>
+                                    <exclude>net.kyori:examination-api</exclude>
+                                    <exclude>net.kyori:examination-string</exclude>
+                                    <exclude>org.jetbrains:annotations</exclude>
+                                    <exclude>org.intellij.lang:annotations</exclude>
+                                </excludes>
+                            </artifactSet>
                         </configuration>
                     </execution>
                 </executions>

CommandWhitelistVelocity/src/main/java/eu/endermite/commandwhitelist/velocity/CommandWhitelistVelocity.java

@@ -1,6 +1,7 @@
 package eu.endermite.commandwhitelist.velocity;
 
-import com.velocitypowered.api.command.CommandMeta;
+import com.google.inject.Injector;
+import com.mojang.brigadier.Command;
 import com.velocitypowered.api.command.CommandSource;
 import com.velocitypowered.api.event.Subscribe;
 import com.velocitypowered.api.event.command.CommandExecuteEvent;
@@ -15,13 +16,11 @@ import eu.endermite.commandwhitelist.common.CommandUtil;
 import eu.endermite.commandwhitelist.common.ConfigCache;
 import eu.endermite.commandwhitelist.common.commands.CWCommand;
 import eu.endermite.commandwhitelist.velocity.command.VelocityMainCommand;
-import net.kyori.adventure.identity.Identity;
 import org.bstats.charts.SimplePie;
 import org.bstats.velocity.Metrics;
 import org.slf4j.Logger;
 
 import javax.inject.Inject;
-import java.io.File;
 import java.nio.file.Path;
 import java.util.ArrayList;
 import java.util.HashMap;
@@ -30,51 +29,57 @@ import java.util.Map;
 
 public class CommandWhitelistVelocity {
 
-    private static CommandWhitelistVelocity plugin;
+    private final ProxyServer server;
-    private static ProxyServer server;
+    private ConfigCache configCache;
-    private static ConfigCache configCache;
+    private final Path folder;
-    private static Path folder;
+    private final Logger logger;
-    private static Logger logger;
     private final Metrics.Factory metricsFactory;
+    private final Injector injector;
 
     @Inject
-    public CommandWhitelistVelocity(ProxyServer server, Logger logger, @DataDirectory final Path folder, Metrics.Factory metricsFactory) {
+    public CommandWhitelistVelocity(
-        CommandWhitelistVelocity.server = server;
+            ProxyServer server,
-        CommandWhitelistVelocity.folder = folder;
+            Logger logger,
-        CommandWhitelistVelocity.plugin = this;
+            @DataDirectory final Path folder,
-        CommandWhitelistVelocity.logger = logger;
+            Metrics.Factory metricsFactory,
+            Injector injector
+    ) {
+        this.server = server;
+        this.folder = folder;
+        this.logger = logger;
         this.metricsFactory = metricsFactory;
-
+        this.injector = injector;
     }
 
-    private static void reloadConfig() {
+    private void reloadConfig() {
         if (configCache == null)
-            configCache = new ConfigCache(new File(String.valueOf(folder), "config.yml"), false, logger);
+            configCache = new ConfigCache(folder.resolve("config.yml").toFile(), false, logger);
         else
             configCache.reloadConfig();
     }
 
-    public static void reloadConfig(CommandSource source) {
+    public int reloadConfig(CommandSource source) {
-        server.getScheduler().buildTask(plugin, () -> {
+        server.getScheduler().buildTask(this, () -> {
             reloadConfig();
-            source.sendMessage(Identity.nil(), CWCommand.miniMessage.deserialize(getConfigCache().prefix + getConfigCache().config_reloaded));
+            source.sendMessage(CWCommand.miniMessage.deserialize(getConfigCache().prefix + getConfigCache().config_reloaded));
         }).schedule();
+        return Command.SINGLE_SUCCESS;
     }
 
     @Subscribe
     public void onProxyInitialization(ProxyInitializeEvent event) {
         reloadConfig();
-        CommandMeta commandMeta = server.getCommandManager().metaBuilder("vcw").build();
+        injector.getInstance(VelocityMainCommand.class).register();
-        server.getCommandManager().register(commandMeta, new VelocityMainCommand());
         Metrics metrics = metricsFactory.make(this, 8704);
         metrics.addCustomChart(new SimplePie("proxy", () -> "Velocity"));
     }
 
     @Subscribe
+    @SuppressWarnings("UnstableApiUsage")
     public void onUserCommandSendEvent(PlayerAvailableCommandsEvent event) {
         Player player = event.getPlayer();
         if (player.hasPermission(CWPermission.BYPASS.permission())) return;
-        HashSet<String> allowedCommands = CommandWhitelistVelocity.getCommands(player);
+        HashSet<String> allowedCommands = getCommands(player);
         event.getRootNode().getChildren().removeIf((commandNode) ->
                 server.getCommandManager().hasCommand(commandNode.getName())
                         && !allowedCommands.contains(commandNode.getName())
@@ -82,7 +87,7 @@ public class CommandWhitelistVelocity {
     }
 
     @Subscribe
-    public void onUserCommandExecuteEvent(com.velocitypowered.api.event.command.CommandExecuteEvent event) {
+    public void onUserCommandExecuteEvent(CommandExecuteEvent event) {
         if (!(event.getCommandSource() instanceof Player)) return;
         Player player = (Player) event.getCommandSource();
 
@@ -91,25 +96,21 @@ public class CommandWhitelistVelocity {
         // Workaround for velocity executing "/ command" as valid command
         String command = event.getCommand().trim();
 
-        HashSet<String> allowedCommands = CommandWhitelistVelocity.getCommands(player);
+        HashSet<String> allowedCommands = getCommands(player);
         String label = CommandUtil.getCommandLabel(command);
         if (server.getCommandManager().hasCommand(label) && !allowedCommands.contains(label))
             event.setResult(CommandExecuteEvent.CommandResult.forwardToServer());
     }
 
-    public static ConfigCache getConfigCache() {
+    public ConfigCache getConfigCache() {
         return configCache;
     }
 
-    public static Path getConfigPath() {
-        return folder;
-    }
-
     /**
      * @param player Velocity Player
      * @return commands available to the player
      */
-    public static HashSet<String> getCommands(Player player) {
+    public HashSet<String> getCommands(Player player) {
         HashMap<String, CWGroup> groups = configCache.getGroupList();
         HashSet<String> commandList = new HashSet<>();
         for (Map.Entry<String, CWGroup> s : groups.entrySet()) {
@@ -126,7 +127,7 @@ public class CommandWhitelistVelocity {
      * @param player Velocity Player
      * @return subcommands unavailable for the player
      */
-    public static HashSet<String> getSuggestions(Player player, HashMap<String, CWGroup> groups) {
+    public HashSet<String> getSuggestions(Player player, HashMap<String, CWGroup> groups) {
         HashSet<String> suggestionList = new HashSet<>();
         for (Map.Entry<String, CWGroup> s : groups.entrySet()) {
             if (s.getKey().equalsIgnoreCase("default"))
@@ -137,7 +138,7 @@ public class CommandWhitelistVelocity {
         return suggestionList;
     }
 
-    public static ArrayList<String> getServerCommands() {
+    public ArrayList<String> getServerCommands() {
         return new ArrayList<>(server.getCommandManager().getAliases());
     }
 

CommandWhitelistVelocity/src/main/java/eu/endermite/commandwhitelist/velocity/command/VelocityMainCommand.java

@@ -1,104 +1,143 @@
 package eu.endermite.commandwhitelist.velocity.command;
 
+import com.google.inject.Inject;
+import com.mojang.brigadier.Command;
+import com.mojang.brigadier.arguments.StringArgumentType;
+import com.mojang.brigadier.builder.LiteralArgumentBuilder;
+import com.mojang.brigadier.builder.RequiredArgumentBuilder;
+import com.mojang.brigadier.tree.LiteralCommandNode;
+import com.velocitypowered.api.command.BrigadierCommand;
+import com.velocitypowered.api.command.CommandManager;
 import com.velocitypowered.api.command.CommandSource;
-import com.velocitypowered.api.command.SimpleCommand;
+import com.velocitypowered.api.permission.Tristate;
+import com.velocitypowered.api.plugin.annotation.DataDirectory;
+import eu.endermite.commandwhitelist.common.CWGroup;
 import eu.endermite.commandwhitelist.common.CWPermission;
 import eu.endermite.commandwhitelist.common.CommandUtil;
+import eu.endermite.commandwhitelist.common.ConfigCache;
 import eu.endermite.commandwhitelist.common.commands.CWCommand;
 import eu.endermite.commandwhitelist.velocity.CommandWhitelistVelocity;
 import net.kyori.adventure.text.Component;
 
-import java.io.File;
+import java.nio.file.Path;
-import java.util.ArrayList;
-import java.util.List;
-import java.util.concurrent.CompletableFuture;
 
-public class VelocityMainCommand implements SimpleCommand {
+public final class VelocityMainCommand {
+    @Inject
+    private CommandManager commandManager;
+    @Inject
+    private CommandWhitelistVelocity plugin;
+    @Inject
+    @DataDirectory
+    private Path dataDirectory;
 
-    @Override
+    public void register() {
-    public void execute(final Invocation invocation) {
+        LiteralCommandNode<CommandSource> node = LiteralArgumentBuilder
-        CommandSource sender = invocation.source();
+                .<CommandSource>literal("vcw")
-        String[] args = invocation.arguments();
+                .requires(src -> src.getPermissionValue("commandwhitelist.command") != Tristate.FALSE)
-        String label = invocation.alias();
+                .executes(ctx -> {
+                    CommandSource source = ctx.getSource();
+                    source.sendMessage(CWCommand.helpComponent("vcw", source.hasPermission(CWPermission.RELOAD.permission()), source.hasPermission(CWPermission.ADMIN.permission())));
+                    return Command.SINGLE_SUCCESS;
+                })
+                .then(LiteralArgumentBuilder.<CommandSource>literal("reload")
+                    .requires(src -> src.hasPermission(CWPermission.RELOAD.permission()))
+                    .executes(ctx -> plugin.reloadConfig(ctx.getSource()))
+                )
+                .then(LiteralArgumentBuilder.<CommandSource>literal("add")
+                    .requires(src -> src.hasPermission(CWPermission.ADMIN.permission()))
+                    .then(RequiredArgumentBuilder.<CommandSource, String>argument("group", StringArgumentType.word())
+                        .suggests((ctx, builder) -> {
+                            plugin.getConfigCache().getGroupList().keySet().forEach(builder::suggest);
+                            return builder.buildFuture();
+                        })
+                        .then(RequiredArgumentBuilder.<CommandSource, String>argument("command", StringArgumentType.word())
+                            .suggests((ctx, builder) -> {
+                                CWGroup group = plugin.getConfigCache().getGroupList().get(ctx.getArgument("group", String.class));
+                                if (group == null) return builder.buildFuture();
 
-        if (args.length == 0) {
+                                for (String cmd : plugin.getServerCommands()) {
-            sender.sendMessage(CWCommand.helpComponent(label, sender.hasPermission(CWPermission.RELOAD.permission()), sender.hasPermission(CWPermission.ADMIN.permission())));
+                                    if (cmd.charAt(0) == '/')
-            return;
+                                        cmd = cmd.substring(1);
-        }
+                                    if (cmd.indexOf(':') != -1) {
+                                        String[] cmdSplit = cmd.split(":");
+                                        if (cmdSplit.length < 2) continue;
+                                        cmd = cmdSplit[1];
+                                    }
+                                    if (group.getCommands().contains(cmd)) continue;
+                                    builder.suggest(cmd);
+                                }
+                                return builder.buildFuture();
+                            })
+                            .executes(ctx -> {
+                                CommandSource source = ctx.getSource();
+                                ConfigCache configCache = plugin.getConfigCache();
+                                String arg1 = ctx.getArgument("group", String.class);
+                                String arg2 = ctx.getArgument("command", String.class);
 
-        try {
+                                if (CWCommand.addToWhitelist(configCache, arg2, arg1))
-            CWCommand.CommandType commandType = CWCommand.CommandType.valueOf(args[0].toUpperCase());
+                                    source.sendMessage(CWCommand.miniMessage.deserialize(String.format(configCache.prefix + configCache.added_to_whitelist, arg2, arg1)));
-            switch (commandType) {
+                                else
-                case RELOAD:
+                                    source.sendMessage(CWCommand.miniMessage.deserialize(String.format(configCache.prefix + configCache.group_doesnt_exist, arg1)));
-                    if (!sender.hasPermission(CWPermission.RELOAD.permission())) {
+                                return Command.SINGLE_SUCCESS;
-                        sender.sendMessage(CWCommand.miniMessage.deserialize(CommandWhitelistVelocity.getConfigCache().prefix + CommandWhitelistVelocity.getConfigCache().no_permission));
+                            })
-                        return;
+                        )
-                    }
+                    )
-                    CommandWhitelistVelocity.reloadConfig(sender);
+                )
-                    return;
+                .then(LiteralArgumentBuilder.<CommandSource>literal("remove")
-                case ADD:
+                    .requires(src -> src.hasPermission(CWPermission.ADMIN.permission()))
-                    if (!sender.hasPermission(CWPermission.ADMIN.permission())) {
+                    .then(RequiredArgumentBuilder.<CommandSource, String>argument("group", StringArgumentType.word())
-                        sender.sendMessage(CWCommand.miniMessage.deserialize(CommandWhitelistVelocity.getConfigCache().prefix + CommandWhitelistVelocity.getConfigCache().no_permission));
+                        .suggests((ctx, builder) -> {
-                        return;
+                            plugin.getConfigCache().getGroupList().keySet().forEach(builder::suggest);
-                    }
+                            return builder.buildFuture();
-                    if (args.length == 3) {
+                        })
-                        if (CWCommand.addToWhitelist(CommandWhitelistVelocity.getConfigCache(), args[2], args[1]))
+                        .then(RequiredArgumentBuilder.<CommandSource, String>argument("command", StringArgumentType.word())
-                            sender.sendMessage(CWCommand.miniMessage.deserialize(String.format(CommandWhitelistVelocity.getConfigCache().prefix + CommandWhitelistVelocity.getConfigCache().added_to_whitelist, args[2], args[1])));
+                            .suggests((ctx, builder) -> {
-                        else
+                                CWGroup group = plugin.getConfigCache().getGroupList().get(ctx.getArgument("group", String.class));
-                            sender.sendMessage(CWCommand.miniMessage.deserialize(String.format(CommandWhitelistVelocity.getConfigCache().prefix + CommandWhitelistVelocity.getConfigCache().group_doesnt_exist, args[1])));
+                                if (group == null) return builder.buildFuture();
-                    } else
-                        sender.sendMessage(Component.text("/" + label + " add <group> <command>"));
-                    return;
-                case REMOVE:
-                    if (!sender.hasPermission(CWPermission.ADMIN.permission())) {
-                        sender.sendMessage(CWCommand.miniMessage.deserialize(CommandWhitelistVelocity.getConfigCache().prefix + CommandWhitelistVelocity.getConfigCache().no_permission));
-                        return;
-                    }
-                    if (args.length == 3) {
-                        if (CWCommand.removeFromWhitelist(CommandWhitelistVelocity.getConfigCache(), args[2], args[1]))
-                            sender.sendMessage(CWCommand.miniMessage.deserialize(String.format(CommandWhitelistVelocity.getConfigCache().prefix + CommandWhitelistVelocity.getConfigCache().removed_from_whitelist, args[2], args[1])));
-                        else
-                            sender.sendMessage(CWCommand.miniMessage.deserialize(String.format(CommandWhitelistVelocity.getConfigCache().prefix + CommandWhitelistVelocity.getConfigCache().group_doesnt_exist, args[1])));
-                    } else
-                        sender.sendMessage(Component.text("/" + label + " remove <group> <command>"));
-                    return;
-                case DUMP:
-                    if (!sender.hasPermission(CWPermission.ADMIN.permission())) {
-                        sender.sendMessage(CWCommand.miniMessage.deserialize(CommandWhitelistVelocity.getConfigCache().prefix + CommandWhitelistVelocity.getConfigCache().no_permission));
-                        return;
-                    }
-                    sender.sendMessage(Component.text("Dumping all available commands to a file..."));
-                    if (CommandUtil.dumpAllBukkitCommands(CommandWhitelistVelocity.getServerCommands(), new File(String.valueOf(CommandWhitelistVelocity.getConfigPath()), "command_dump.yml"))) {
-                        sender.sendMessage(Component.text("Commands dumped to command_dump.yml"));
-                    } else {
-                       sender.sendMessage(Component.text("Failed to save the file."));
-                    }
-                    return;
-                case HELP:
-                default:
-                    sender.sendMessage(CWCommand.helpComponent(label, sender.hasPermission(CWPermission.RELOAD.permission()), sender.hasPermission(CWPermission.ADMIN.permission())));
-            }
 
-        } catch (IllegalArgumentException e) {
+                                for (String s : group.getCommands()) {
-            sender.sendMessage(CWCommand.helpComponent(label, sender.hasPermission(CWPermission.RELOAD.permission()), sender.hasPermission(CWPermission.ADMIN.permission())));
+                                    builder.suggest(s);
-        }
+                                }
-        return;
+                                return builder.buildFuture();
-    }
+                            })
+                            .executes(ctx -> {
+                                CommandSource source = ctx.getSource();
+                                ConfigCache configCache = plugin.getConfigCache();
+                                String arg1 = ctx.getArgument("group", String.class);
+                                String arg2 = ctx.getArgument("command", String.class);
 
-    @Override
+                                if (CWCommand.removeFromWhitelist(configCache, arg2, arg1))
-    public CompletableFuture<List<String>> suggestAsync(Invocation invocation) {
+                                    source.sendMessage(CWCommand.miniMessage.deserialize(String.format(configCache.prefix + configCache.removed_from_whitelist, arg2, arg1)));
-        CommandSource source = invocation.source();
+                                else
-        String[] args = invocation.arguments();
+                                    source.sendMessage(CWCommand.miniMessage.deserialize(String.format(configCache.prefix + configCache.group_doesnt_exist, arg1)));
-        return CompletableFuture.supplyAsync(() -> {
+                                return Command.SINGLE_SUCCESS;
-            List<String> serverCommands = CommandWhitelistVelocity.getServerCommands();
+                            })
-            return CWCommand.commandSuggestions(
+                        )
-                    CommandWhitelistVelocity.getConfigCache(),
+                    )
-                    serverCommands,
+                )
-                    args,
+                .then(LiteralArgumentBuilder.<CommandSource>literal("dump")
-                    source.hasPermission(CWPermission.RELOAD.permission()),
+                    .requires(src -> src.hasPermission(CWPermission.ADMIN.permission()))
-                    source.hasPermission(CWPermission.ADMIN.permission()),
+                    .executes(ctx -> {
-                    CWCommand.ImplementationType.VELOCITY
+                        CommandSource source = ctx.getSource();
-            );
+                        source.sendMessage(Component.text("Dumping all available commands to a file..."));
-        });
+                        if (CommandUtil.dumpAllBukkitCommands(plugin.getServerCommands(), dataDirectory.resolve("command_dump.yml").toFile())) {
+                            source.sendMessage(Component.text("Commands dumped to command_dump.yml"));
+                        } else {
+                            source.sendMessage(Component.text("Failed to save the file."));
+                        }
+                        return Command.SINGLE_SUCCESS;
+                    })
+                )
+                .then(LiteralArgumentBuilder.<CommandSource>literal("help")
+                    .executes(ctx -> {
+                        CommandSource source = ctx.getSource();
+                        source.sendMessage(CWCommand.helpComponent("cw", source.hasPermission(CWPermission.RELOAD.permission()), source.hasPermission(CWPermission.ADMIN.permission())));
+                        return Command.SINGLE_SUCCESS;
+                    })
+                )
+                .build();
+
+        final BrigadierCommand command = new BrigadierCommand(node);
+        commandManager.register(commandManager.metaBuilder(command).plugin(plugin).build(), command);
     }
 }